Adding implementation and tests for admin write commands. #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| &flags.NetworkFlag, | ||
| &flags.EnvironmentFlag, | ||
| &flags.ETHRpcUrlFlag, | ||
| &PermissionControllerAddressFlag, | ||
| } | ||
| sort.Sort(cli.FlagsByName(cmdFlags)) |
There was a problem hiding this comment.
did not realize before but you should append signer flags first and then sort - so that all flags are sorted
There was a problem hiding this comment.
Gonna pick this up in the flag review.
| func acceptFlags() []cli.Flag { | ||
| cmdFlags := []cli.Flag{ | ||
| &flags.VerboseFlag, | ||
| &AccountAddressFlag, | ||
| &flags.OutputTypeFlag, |
There was a problem hiding this comment.
are you going to add broadcast flag and corresponding feature later?
There was a problem hiding this comment.
Yeah, going to do a sweep over all flags in a separate PR.
| return nil, eigenSdkUtils.WrapError("failed to create new eth client", err) | ||
| } | ||
| elWriter, err := common.GetELWriter( | ||
| config.AccountAddress, |
There was a problem hiding this comment.
you can just return common.GetELWriter (..) instead of creating vars which you return in next line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding implementation and tests for admin write commands.
What Changed?